Fix(docs): add reminder to include .gts file to .eslintrc config
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how much many addons we should remind for, but I forgot to update my tailwind config and after converting some files to gjs, tailwind dropped some of the classes they were using. Updating the config to include gjs files brought them back. |
| @@ -69,6 +69,17 @@ include `@glint/environment-ember-template-imports`!) | |||
| [glint]: https://typed-ember.gitbook.io/glint | |||
| [glint-setup]: https://typed-ember.gitbook.io/glint/environments/ember/installation | |||
|
|
|||
| Make sure also to add support for `.gts` files into your `.eslintrc.js` configuration. | |||
There was a problem hiding this comment.
I think this may change with an upcoming release of eslint-plugin-ember, where it ships its own gts parser
|
Gonna close because the .eslintrc requirements are a bit different now. I appreciate you taking the time to submit this though! <3 See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reminder to include
.gtsfile to.eslintrcconfig.