fix: reimplement Tray with StatusIconLinuxDbus on Linux #36333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
target/20-x-y
target/21-x-y
2 tasks
|
@MarshallOfSound It is still there :(, I'll see if I can fix it. |
deepak1556
reviewed
Nov 15, 2022
|
I have submitted a patch to upstream Chromium to fix the tray icon disappearing problem: |
deepak1556
approved these changes
Nov 15, 2022
|
I saw we updated the Tray documentation - is there anything else that Linux developers/users would need to modify in their app for these Tray changes, or should they work out of the box? |
Existing apps will just work without any modification, this PR only fixes limitations of previous implementation without changing existing behaviors. |
codebytere
approved these changes
Nov 22, 2022
2 tasks
nornagon
approved these changes
Nov 28, 2022
Comment on lines
+32
to
+33
| * Tray icon requires support of [StatusNotifierItem](https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/) | ||
| in user's desktop environment. |
There was a problem hiding this comment.
Suggested change
| * Tray icon requires support of [StatusNotifierItem](https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/) | |
| in user's desktop environment. | |
| * The user's desktop environment must support [StatusNotifierItem](https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/) | |
| in order to display a tray icon. |
Comment on lines
+34
to
+37
| * The `click` event is emitted when the tray icon receives activation from | ||
| user, however the StatusNotifierItem spec does not specify which action would | ||
| cause an activation, for some environments it is left mouse click, but for | ||
| some it might be double left mouse click. |
There was a problem hiding this comment.
Suggested change
| * The `click` event is emitted when the tray icon receives activation from | |
| user, however the StatusNotifierItem spec does not specify which action would | |
| cause an activation, for some environments it is left mouse click, but for | |
| some it might be double left mouse click. | |
| * The `click` event is emitted when the tray icon receives activation from the | |
| user. However, the StatusNotifierItem spec does not specify which interactions | |
| cause an activation. For some environments, a left mouse click causes an | |
| activation, but for others it might be double left mouse click, or some other | |
| interaction. |
Comment on lines
+92
to
+93
| Note that on Linux this event is emitted when the tray icon receives an | ||
| activation, which might not necessarily be left mouse click. |
There was a problem hiding this comment.
Suggested change
| Note that on Linux this event is emitted when the tray icon receives an | |
| activation, which might not necessarily be left mouse click. | |
| Note that on Linux this event is emitted when the tray icon receives an | |
| activation, which might not necessarily be a left mouse click. |
|
Release Notes Persisted
|
trop
bot
removed
the
target/21-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36472 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
trop
bot
added
merged/22-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Nov 29, 2022
* fix: reimplement Tray with StatusIconLinuxDbus on Linux (#36333) Co-authored-by: Cheng Zhao <zcbenz@gmail.com> * chore: remove incorrectly added patches Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
5 tasks
2 tasks
2 tasks
3 tasks
6 tasks
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR rewrites Tray's implementation on Linux with
StatusIconLinuxDbus, which communicates with the desktop environment with dbus directly instead of relying on libappindicator.Close #36283.
Close #36274.
Close #28956.
Close #28131.
Close #27527.
Close #14941.
Close #14635.
Release Notes
Notes: Fix
clickevent and tooltip ofTraynot working on Linux.