fix: fallback to GtkStatusIcon when app indicator is not supported #36815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
target/22-x-y
6 tasks
zcbenz
force-pushed
the
tray-gtk-backend
branch
from
317347c
to
61927f9
Compare
4 tasks
zcbenz
force-pushed
the
tray-gtk-backend
branch
from
61927f9
to
b13ef08
Compare
|
Release Notes Persisted
|
|
I was unable to backport this PR to "22-x-y" cleanly; |
trop
bot
added
needs-manual-bp/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "23-x-y", please check out #37033 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
zcbenz
added a commit
that referenced
this pull request
Jan 26, 2023
…36815) * chore: get ready for multi backend tray * fix: fallback to GtkStatusIcon when app indicator is not supported * chore: use smart pointers
trop
bot
added
in-flight/22-x-y
merged/23-x-y
codebytere
pushed a commit
that referenced
this pull request
Jan 26, 2023
…37034) * refactor: make StatusIconType an enum class (#36554) Co-authored-by: Milan Burda <miburda@microsoft.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Milan Burda <miburda@microsoft.com> * fix: fallback to GtkStatusIcon when app indicator is not supported (#36815) * chore: get ready for multi backend tray * fix: fallback to GtkStatusIcon when app indicator is not supported * chore: use smart pointers Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Milan Burda <miburda@microsoft.com>
trop
bot
added
merged/22-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…lectron#36815) * chore: get ready for multi backend tray * fix: fallback to GtkStatusIcon when app indicator is not supported * chore: use smart pointers
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
…lectron#36815) * chore: get ready for multi backend tray * fix: fallback to GtkStatusIcon when app indicator is not supported * chore: use smart pointers
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix #36602.
Refs #36333.
Some desktop environments (for example i3wm) does not support the modern app indicator, and we have to fallback to use the deprecated
GtkStatusIconAPI to make tray icons show there.Release Notes
Notes: Fix tray icon not showing on desktop environments that have no support for app indicator.