Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a note that Tray setImage can segfault on Linux #36432

Closed
wants to merge 1 commit into from

Conversation

Atharva-17
Copy link

@Atharva-17 Atharva-17 commented Nov 23, 2022

Description of Change

Added a note in tray.md that "setImage is known to cause segfaults, and should not be used on Linux". With reference to issue #36274

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Nov 23, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Nov 23, 2022
@VerteDinde
Copy link
Member

Hey @Atharva-17, thanks for the PR! I'm sorry, we should have removed the "documentation" and "beginner-friendly" labels from this issue - this issue is actually addressed in #36333, which we decided to fix rather than update the documentation.

I'm going to close this PR, but thanks for contributing to Electron! If you're affected by this Linux issue, we hope the linked PR fixes the issue for you. If you're looking to contribute to Electron, we could also use contributors in Electron Forge and Electron Fiddle and have more issues open there 🙂

@VerteDinde VerteDinde closed this Nov 24, 2022
@Atharva-17
Copy link
Author

@VerteDinde Thanks for the status! I will definitely check the repository of Electron Forge and Electron Fiddle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants