Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add webContents.close() #35509

Merged
merged 4 commits into from Sep 16, 2022
Merged

feat: add webContents.close() #35509

merged 4 commits into from Sep 16, 2022

Conversation

nornagon
Copy link
Member

Description of Change

Adds webContents.close(), which has roughly the same effect as the page
calling window.close(). Closes #26929.

There was some discussion in #26929 about having a WebContents be reusable
after close, but after studying the //content API for a while, I'm not sure
that's reasonable to implement, since content::WebContents is only closable by
destroying it.

Checklist

Release Notes

Notes: Added webContents.close() method.

@nornagon nornagon added no-backport semver/minor backwards-compatible functionality labels Aug 30, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Aug 30, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2022
jkleinsc
jkleinsc reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc reviewed Sep 7, 2022
View reviewed changes
docs/api/web-contents.md Outdated Show resolved Hide resolved
denox55
denox55 reviewed Sep 8, 2022
View reviewed changes
Copy link

@denox55 denox55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

().

samuelmaddock
samuelmaddock approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@ckerr
Copy link
Member

ckerr commented Sep 15, 2022

API LGTM

ckerr
ckerr approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@ckerr ckerr merged commit eebf34c into main Sep 16, 2022
@ckerr ckerr deleted the web-contents-close branch September 16, 2022 23:23
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2022

Release Notes Persisted

Added webContents.close() method.

@mesner mesner mentioned this pull request Nov 3, 2022
Open
3 tasks
@codebytere codebytere mentioned this pull request Nov 17, 2022
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request Jan 11, 2023
Open
@YauheniBH-EF YauheniBH-EF mentioned this pull request Feb 7, 2023
Closed
3 tasks
@codebytere codebytere mentioned this pull request Feb 9, 2023
Merged
3 tasks
@PascalPixel
Copy link

browserView.webContents.close() no longer stops a video from being played in Electron 23, the audio continues after closing a YouTube frame, it stopped it in Electron 22. Am now calling browserView.webContents.destroy() to get it to stop.

@nornagon
Copy link
Member Author

@PascalPixel please open a new issue with a repro, thanks!

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
feat: add webContents.close() (electron#35509)
c511510 
* feat: add webContents.close()

* update docs, add test for beforeunload override

* Update web-contents.md
@codebytere codebytere mentioned this pull request Feb 27, 2023
Merged
4 tasks
@rak-phillip rak-phillip mentioned this pull request Apr 10, 2023
Closed
@codebytere codebytere mentioned this pull request Jul 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc left review comments

@codebytere codebytere codebytere left review comments

@erickzhao erickzhao erickzhao left review comments

@denox55 denox55 denox55 left review comments

@ckerr ckerr ckerr approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Documented way to close a WebContents
8 participants
@nornagon @ckerr @PascalPixel @jkleinsc @samuelmaddock @codebytere @erickzhao @denox55