fix: webview crash when removing in close event #38996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-destroy-webcontents-webview
branch
from
d446610
to
7e920c6
Compare
codebytere
force-pushed
the
fix-destroy-webcontents-webview
branch
from
7e920c6
to
00c34fe
Compare
zcbenz
approved these changes
Jul 6, 2023
|
Release Notes Persisted
|
This was referenced Jul 6, 2023
|
I have automatically backported this PR to "26-x-y", please check out #39007 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "25-x-y", please check out #39008 |
|
I have automatically backported this PR to "24-x-y", please check out #39009 |
trop
bot
added
in-flight/25-x-y
in-flight/24-x-y
merged/26-x-y
trop
bot
added
merged/24-x-y
3 tasks
3 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #38941.
Fixes an issue where removing a webview in a close callback could cause crashes. This happened as a result of a change made in #35509, where
WebContents::CloseContentswas changed to callDestroyinstead of it being called inOnCloseContentsby aBrowserWindoworBrowserView. This made it the case thatDestroy()would also now be called for webview webContents', which could lead to crashes since that was previously handled by the embedder frame.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where removing a webview in a close callback could cause crashes.