Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDX: Replace BrowserView.webContents.destroy() with BrowserView.webContents.close() #4394

Closed
rak-phillip opened this issue Apr 10, 2023 · 2 comments · Fixed by #5921
Closed

RDX: Replace BrowserView.webContents.destroy() with BrowserView.webContents.close() #4394

rak-phillip opened this issue Apr 10, 2023 · 2 comments · Fixed by #5921
Assignees
@rak-phillip
Labels
area/rdx component/ui kind/bug Something isn't working
Milestone
1.12

Comments

@rak-phillip
Copy link
Contributor

We had to implement the undocumented webContents.destroy() method in order to resolve #4393.

Later versions of electron provide a webContents.close() but we will need to update our electron version before we can consume this method.

Reference

electron/electron#35509
@rak-phillip rak-phillip mentioned this issue Apr 10, 2023
Merged
@mook-as mook-as mentioned this issue Apr 18, 2023
Closed
14 tasks
@rak-phillip rak-phillip added this to the 1.10 milestone Apr 28, 2023
@rak-phillip
Copy link
Contributor Author

@gunamata @jandubois Dropping from epic & moving to 1.10

@rak-phillip rak-phillip mentioned this issue Apr 28, 2023
Closed
15 tasks
@gaktive
Copy link
Contributor

gaktive commented Jul 6, 2023

Epic referred to #4580

@gaktive gaktive modified the milestones: 1.10, 1.11 Aug 17, 2023
@gaktive gaktive modified the milestones: 1.11, 1.12 Oct 3, 2023
@rak-phillip rak-phillip mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rak-phillip rak-phillip

Labels
area/rdx component/ui kind/bug Something isn't working
Projects
None yet
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Replace BrowserView.webContents.destroy() rak-phillip/rancher-desktop
2 participants
@rak-phillip @gaktive