Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty result of webContents.getUserAgent() #35069

Merged
merged 1 commit into from Jul 29, 2022
Merged

fix: empty result of webContents.getUserAgent() #35069

merged 1 commit into from Jul 29, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #35046.

Refs #34481 - this change made it such that we were no longer initializing the user agent and so it would always be empty when calling webContents.getUserAgent() unless it had been previously set by webContents.setUserAgent(agent). This fixes that, and incidentally removes the need to have a separate GetUserAgentOverride.

Confirmed not to regress #30201

Checklist

Release Notes

Notes: Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/20-x-y labels Jul 26, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2022
@JCMais
Copy link

JCMais commented Jul 26, 2022

This seems to be affecting the latest v19 patch release too, so a backport may be needed

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 27, 2022
@miniak
Copy link
Contributor

miniak commented Jul 27, 2022

@codebytere why not 17-x-y? The previous fix, which regressed this was backported to 17-x-y

@codebytere
Copy link
Member Author

@miniak 17 is security fixes only

@miniak
Copy link
Contributor

miniak commented Jul 27, 2022

@codebytere theoretically yes, but that's not what's been done if you check the commit history

@jkleinsc jkleinsc merged commit 9028bb7 into main Jul 29, 2022
@jkleinsc jkleinsc deleted the fix-ua branch July 29, 2022 15:09
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2022

Release Notes Persisted

Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

@trop
Copy link
Contributor

trop bot commented Jul 29, 2022

I have automatically backported this PR to "18-x-y", please check out #35130

@trop
Copy link
Contributor

trop bot commented Jul 29, 2022

I have automatically backported this PR to "20-x-y", please check out #35131

@trop
Copy link
Contributor

trop bot commented Jul 29, 2022

I have automatically backported this PR to "19-x-y", please check out #35132

@miniak
Copy link
Contributor

miniak commented Jul 31, 2022

/trop run backport-to 17-x-y

@trop
Copy link
Contributor

trop bot commented Jul 31, 2022

The backport process for this PR has been manually initiated - sending your PR to 17-x-y!

@trop
Copy link
Contributor

trop bot commented Jul 31, 2022

I have automatically backported this PR to "17-x-y", please check out #35151

@KrisanaSangduen
Copy link

ฉันไม่มีความรู้ความสามารถในการใช้งาน ฉันอยากขอความร่วมมือให้ทุกฝ่ายช่วยประสานงาน ส่งข้อมูลส่วนตัวที่เกี่ยวกับเนื้อหาในการเปิดเผยข้อมูลส่วนตัว และช่วยประชาสัมพันธ์ต่อสื่อสาธารณะที่เหมาะสม และให้เงินทุนสนับสนุนก่อนที่ฉันจะเข้าร่มงานและฝึกทักษะการเนียนรู้ในอนาคตข้างหน้า

schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
fix: empty result of webContents.getUserAgent()
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
fix: empty result of webContents.getUserAgent()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: webContents.getUserAgent() is empty since 20.0.0-alpha.6
6 participants