Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty result of webContents.getUserAgent() #35132

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 29, 2022

Backport of #35069

See that PR for details.

Notes: Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@trop trop bot requested a review from codebytere July 29, 2022 15:10
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@github-actions
Copy link
Contributor

electron-woa-testing

       2 files     900 suites   23m 41s ⏱️
2 109 tests 2 109 ✔️ 0 💤 0
2 397 runs  2 397 ✔️ 0 💤 0

Results for commit 20cf4a4.

@codebytere codebytere merged commit 4fa6f61 into 19-x-y Jul 29, 2022
@codebytere codebytere deleted the trop/19-x-y-bp-fix-empty-result-of-webcontents-getuseragent--1659107415949 branch July 29, 2022 20:51
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2022

Release Notes Persisted

Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant