Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty result of webContents.getUserAgent() #35151

Merged
merged 1 commit into from Aug 2, 2022
Merged

fix: empty result of webContents.getUserAgent() #35151

merged 1 commit into from Aug 2, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 31, 2022

Backport of #35069

See that PR for details.

Notes: Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2022
@trop trop bot requested a review from codebytere July 31, 2022 19:06
@trop trop bot mentioned this pull request Jul 31, 2022
Merged
4 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2022
@github-actions
Copy link
Contributor

electron-woa-testing

       2 files     899 suites   25m 46s ⏱️
2 137 tests 2 135 ✔️ 0 💤 2 ❌
2 411 runs  2 409 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 06fd94e.

@MarshallOfSound MarshallOfSound merged commit 500071a into 17-x-y Aug 2, 2022
@MarshallOfSound MarshallOfSound deleted the trop/17-x-y-bp-fix-empty-result-of-webcontents-getuseragent--1659294395000 branch August 2, 2022 18:53
@release-clerk
Copy link

release-clerk bot commented Aug 2, 2022

Release Notes Persisted

Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound