build: change upload-to-s3 vars to upload-to-storage #34105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
VerteDinde
changed the title
VerteDinde
force-pushed
the
upload-to-az-variable-change
branch
from
b304471
to
1accc24
Compare
codebytere
approved these changes
May 9, 2022
jkleinsc
approved these changes
May 9, 2022
jkleinsc
requested changes
May 9, 2022
There was a problem hiding this comment.
overall this PR is fine but @MarshallOfSound discovered an issue where usingupload-to-s3 causes overwriting the headers tarballs of legit releases. @MarshallOfSound's suggestion was that this flag should upload to a different container to prevent contention.
jkleinsc
approved these changes
May 9, 2022
|
No Release Notes |
This was referenced May 9, 2022
|
I have automatically backported this PR to "15-x-y", please check out #34142 |
This was referenced May 9, 2022
|
I have automatically backported this PR to "19-x-y", please check out #34143 |
|
I have automatically backported this PR to "17-x-y", please check out #34144 |
|
I have automatically backported this PR to "16-x-y", please check out #34145 |
|
I have automatically backported this PR to "18-x-y", please check out #34146 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* build: change upload-to-s3 vars to upload-to-az * build: change upload-to-az to upload-to-storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A follow up to #34104, this PR changes all instances of
upload-to-s3toupload-to-storage. We now use Azure, and this variable is now platform agnostic, should we want to switch platforms in the future.Please do not merge until the first PR is merged, and all instances of this variable have been confirmed changed in CircleCI and AppVeyor.This PR is ready for review. I checked both Appveyor and CircleCI, and neither appears to be storing a default value for UPLOAD_TO_S3. Since both already contain the necessary info for Azure, I think this should "just work".
Checklist
npm testpassesRelease Notes
Notes: no-notes