build: stop uploading assets to S3 #34104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MarshallOfSound
approved these changes
May 5, 2022
|
No Release Notes |
This was referenced May 6, 2022
|
I have automatically backported this PR to "15-x-y", please check out #34112 |
|
I have automatically backported this PR to "16-x-y", please check out #34113 |
|
I have automatically backported this PR to "18-x-y", please check out #34114 |
|
I have automatically backported this PR to "17-x-y", please check out #34115 |
|
I have automatically backported this PR to "19-x-y", please check out #34116 |
5 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR removes uploading Electron assets to a legacy S3 bucket, so that assets will only upload to Azure.
Note: This PR does not change several upload variables (
upload-to-s3,UPLOAD_TO_S3, etc) that will also need to be changed within CircleCI and AppVeyor. These variables will be addressed in a separate follow-up PR (#34105).Checklist
npm testpassesRelease Notes
Notes: no-notes