Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change upload-to-s3 vars to upload-to-storage #34146

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 9, 2022

Backport of #34105

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from a team as a code owner May 9, 2022 13:36
@trop trop bot requested a review from VerteDinde May 9, 2022 13:36
@trop trop bot added 18-x-y backport This is a backport PR semver/none labels May 9, 2022
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI has build error

@VerteDinde
Copy link
Member

Looks like the linux-ia32-publish job doesn't exist on E19 and main, but does on E18 and lower - changed the variable in that job to the correct UPLOAD_TO_STORAGE, just added to each backport 🙇‍♀️

@codebytere codebytere requested a review from jkleinsc May 10, 2022 11:00
@jkleinsc jkleinsc merged commit 448069c into 18-x-y May 11, 2022
@jkleinsc jkleinsc deleted the trop/18-x-y-bp-build-change-upload-to-s3-vars-to-upload-to-storage-1652103379011 branch May 11, 2022 13:59
@release-clerk
Copy link

release-clerk bot commented May 11, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants