Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Failed to serialize arguments" when emitting 'context-menu' for webview #31279

Merged
merged 1 commit into from Oct 4, 2021
Merged

fix: "Failed to serialize arguments" when emitting 'context-menu' for webview #31279

merged 1 commit into from Oct 4, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 4, 2021

Backport of #31259

See that PR for details.

Notes: Fixed "Failed to serialize arguments" error when emitting 'context-menu' event for webview.

@miniak @electron-bot
fix: "Failed to serialize arguments" when emitting 'context-menu' for…
19892c6 
… webview (#31259)

* fix: sanitize params for 'context-menu' event sent over IPC for webview

* Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview"

This reverts commit 7fee455.

* fix: make frame property non-enumerable in params for 'context-menu' event
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 4, 2021
@trop trop bot requested a review from miniak October 4, 2021 18:00
@trop trop bot mentioned this pull request Oct 4, 2021
Merged
4 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 4, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 4, 2021
@VerteDinde VerteDinde merged commit e19f7fb into 15-x-y Oct 4, 2021
@VerteDinde VerteDinde deleted the trop/15-x-y-bp-fix-failed-to-serialize-arguments-when-emitting-context-menu-for-webview-1633370436652 branch October 4, 2021 19:40
@release-clerk
Copy link

release-clerk bot commented Oct 4, 2021

Release Notes Persisted

Fixed "Failed to serialize arguments" error when emitting 'context-menu' event for webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VerteDinde @miniak