Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Failed to serialize arguments" when emitting 'context-menu' for webview #31279

Merged
merged 1 commit into from Oct 4, 2021
Merged

fix: "Failed to serialize arguments" when emitting 'context-menu' for webview #31279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/common/gin_converters/content_converter.cc
View file
Open in desktop
Expand Up @@ -80,7 +80,7 @@ v8::Local<v8::Value> Converter<ContextMenuParamsWithRenderFrameHost>::ToV8(
const auto& params = val.first;
content::RenderFrameHost* render_frame_host = val.second;
gin_helper::Dictionary dict = gin::Dictionary::CreateEmpty(isolate);
dict.SetGetter("frame", render_frame_host);
dict.SetGetter("frame", render_frame_host, v8::DontEnum);
dict.Set("x", params.x);
dict.Set("y", params.y);
dict.Set("linkURL", params.link_url);
Expand Down
6 changes: 4 additions & 2 deletions shell/common/gin_helper/dictionary.h
View file
Open in desktop
Expand Up @@ -111,7 +111,9 @@ class Dictionary : public gin::Dictionary {
}

template <typename K, typename V>
bool SetGetter(const K& key, const V& val) {
bool SetGetter(const K& key,
const V& val,
v8::PropertyAttribute attribute = v8::None) {
AccessorValue<V> acc_value;
acc_value.Value = val;

Expand All @@ -136,7 +138,7 @@ class Dictionary : public gin::Dictionary {
if (gin::TryConvertToV8(info.GetIsolate(), val, &v8_value))
info.GetReturnValue().Set(v8_value);
},
NULL, v8_value_accessor)
nullptr, v8_value_accessor, v8::DEFAULT, attribute)
.ToChecked();
}

Expand Down