fix: "Failed to serialize arguments" when emitting 'context-menu' for webview #31259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
requested changes
Oct 3, 2021
miniak
force-pushed
the
miniak/webview-context-menu
branch
from
46196ed
to
84f680b
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/webview-context-menu
branch
from
84f680b
to
96b8337
Compare
MarshallOfSound
approved these changes
Oct 4, 2021
codebytere
approved these changes
Oct 4, 2021
3 tasks
samuelmaddock
approved these changes
Oct 4, 2021
VerteDinde
added
the
fast-track 🚅
|
Release Notes Persisted
|
|
I have automatically backported this PR to "16-x-y", please check out #31278 |
|
I have automatically backported this PR to "15-x-y", please check out #31279 |
3 tasks
VerteDinde
pushed a commit
that referenced
this pull request
Oct 4, 2021
… webview (#31259) (#31279) * fix: sanitize params for 'context-menu' event sent over IPC for webview * Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview" This reverts commit 7fee455. * fix: make frame property non-enumerable in params for 'context-menu' event Co-authored-by: Milan Burda <milan.burda@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
… webview (electron#31259) * fix: sanitize params for 'context-menu' event sent over IPC for webview * Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview" This reverts commit 7fee455. * fix: make frame property non-enumerable in params for 'context-menu' event
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
… webview (electron#31259) * fix: sanitize params for 'context-menu' event sent over IPC for webview * Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview" This reverts commit 7fee455. * fix: make frame property non-enumerable in params for 'context-menu' event
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
… webview (electron#31259) * fix: sanitize params for 'context-menu' event sent over IPC for webview * Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview" This reverts commit 7fee455. * fix: make frame property non-enumerable in params for 'context-menu' event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #31249 regressed by #30831
Checklist
npm testpassesRelease Notes
Notes: Fixed "Failed to serialize arguments" error when emitting 'context-menu' event for webview.