Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: context-menu for webviews in renderer broken by #30831 #31276

Closed
3 tasks done
Kilian opened this issue Oct 4, 2021 · 2 comments
Closed
3 tasks done

[Bug]: context-menu for webviews in renderer broken by #30831 #31276

Kilian opened this issue Oct 4, 2021 · 2 comments

Comments

@Kilian
Copy link
Member

Kilian commented Oct 4, 2021

Preflight Checklist

Electron Version

15.1.0

What operating system are you using?

Ubuntu

Operating System Version

ubuntu 18.04

What arch are you using?

x64

Last Known Working Electron version

15.0.0

Expected Behavior

When invoking a context-menu event on the webcontents of a webview in the renderer process, the function works and does not give an error.

Actual Behavior

Since #30831 frame is sent along with the params, but frame is not serializable so can not cross from the main process to the renderer process. This results in an error being shown to the user.

Testcase Gist URL

No response

Additional Information

I'm aware that getting the webContents in the renderer process (using @electron/remote) is an antipattern. Still, I feel this is something we should not break in a minor release.

@erickzhao
Copy link
Member

Might be duplicate of #31249?

@miniak miniak closed this as completed Oct 4, 2021
@miniak
Copy link
Contributor

miniak commented Oct 4, 2021

It's a duplicate of #31249. #31259 fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants