Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add frame to context-menu event params #30831

Merged
merged 2 commits into from Sep 21, 2021
Merged

feat: add frame to context-menu event params #30831

merged 2 commits into from Sep 21, 2021

Conversation

samuelmaddock
Copy link
Member

Description of Change

Adds frame property to the context-menu event params.

Checklist

Release Notes

Notes: Added frame property to the params object of the 'context-menu' event.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2021
@samuelmaddock samuelmaddock added semver/minor backwards-compatible functionality target/15-x-y labels Sep 3, 2021
itsananderson
itsananderson approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

docs/api/web-contents.md Outdated Show resolved Hide resolved
zcbenz
zcbenz approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak
Copy link
Contributor

miniak commented Sep 8, 2021

API LGTM

@zcbenz zcbenz merged commit 70c534f into electron:main Sep 21, 2021
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2021

Release Notes Persisted

Added frame property to the params object of the 'context-menu' event.

@trop trop bot mentioned this pull request Sep 21, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 21, 2021

I have automatically backported this PR to "15-x-y", please check out #31057

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2021
@Kilian Kilian mentioned this pull request Oct 4, 2021
Closed
3 tasks
@miniak miniak mentioned this pull request Oct 4, 2021
Merged
4 tasks
@commit-lint commit-lint bot mentioned this pull request Dec 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@itsananderson itsananderson itsananderson approved these changes

@zcbenz zcbenz zcbenz approved these changes

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samuelmaddock @miniak @nornagon @itsananderson @zcbenz @MarshallOfSound