Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to crashpad on linux #30278

Merged
merged 6 commits into from Aug 3, 2021
Merged

feat: switch to crashpad on linux #30278

merged 6 commits into from Aug 3, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jul 26, 2021 •
edited

Description of Change

This enables crashpad by default on Linux, matching Chrome.

Closes #27859.

Checklist

Release Notes

Notes: The crashReporter API is now powered by Crashpad on Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2021
@nornagon nornagon added the semver/major incompatible API changes label Jul 27, 2021
@nornagon
Copy link
Member Author

NB, the linux and mac CI failures are not flake, but are not related to this change.

@nornagon nornagon requested a review from a team as a code owner July 27, 2021 17:35
itsananderson
itsananderson approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@itsananderson itsananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

For the release notes, it is probably worth calling out explicitly which behaviors will change with the migration to Crashpad. The most likely impact I would suggest mentioning is that the default storage path is changing. For apps that have additional tooling or customer support workflows that involve retrieving those raw crash dumps, it would be good to provide a heads up.

@nornagon
Copy link
Member Author

@itsananderson do you think that should go in breaking-changes.md? There's not really enough room for it in the one-liner Notes:

@itsananderson
Copy link
Contributor

Sorry, I forgot to respond, but yes breaking changes sounds good.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2021
@nornagon nornagon merged commit 40e76dc into main Aug 3, 2021
@nornagon nornagon deleted the enable-crashpad-linux branch August 3, 2021 21:01
@release-clerk
Copy link

release-clerk bot commented Aug 3, 2021

Release Notes Persisted

The crashReporter API is now powered by Crashpad on Linux.

@trop trop bot mentioned this pull request Aug 3, 2021
Closed
@trop
Copy link
Contributor

trop bot commented Aug 3, 2021

I have automatically backported this PR to "15-x-y", please check out #30384

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@nornagon @BlackHole1
feat: switch to crashpad on linux (electron#30278)
02bd463
@codebytere codebytere mentioned this pull request Oct 25, 2021
Closed
3 tasks
@codebytere codebytere mentioned this pull request Nov 2, 2021
Merged
3 tasks
@miniak miniak mentioned this pull request Nov 6, 2021
Merged
3 tasks
@koizuka koizuka mentioned this pull request Nov 20, 2021
Merged
@BitYoungjae BitYoungjae mentioned this pull request May 3, 2022
Closed
@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsananderson itsananderson itsananderson approved these changes

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Crashpad on Linux
4 participants
@nornagon @itsananderson @miniak @MarshallOfSound