fix: crash dump location on Linux

[codebytere]

Description of Change

Closes #31643.
Closes #31565

Refs #30278 - now that Electron has switched to Crashpad by default on Linux DIR_CRASH_DUMPS should be the same across supported platforms.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where app.getPath('crashDumps') returned an incorrect path for Linux.

[deepak1556]

LGTM with the directory alignment change but it does not solve the underlying issue reported which is incorrect path of DIR_USER_DATA

The problem arises from

electron/shell/browser/electron_browser_client.cc

Lines 563 to 564 in 2a2a1a8

	std::string switch_value =
	api::crash_reporter::GetClientId() + ",no_channel";

GetClientId touches DIR_USER_DATA for the first time via

electron/shell/browser/api/electron_api_crash_reporter.cc

Lines 89 to 95 in 2a2a1a8

	bool GetClientIdPath(base::FilePath* path) {
	if (base::PathService::Get(electron::DIR_CRASH_DUMPS, path)) {
	*path = path->Append("client_id");
	return true;
	}
	return false;
	}

AppendExtraCommandLineSwitches will also get called for Zygote Process which will get launched before any JS runs which is were we first set the correct name for DIR_USER_DATA and having GetClientId called as part of the Zygote process leads to incorrect directory naming. Looking at the upstream code zygote process is not interested in switches::kEnableCrashReporter value, so we can just ignore this block for it to fix the root issue here.

[deepak1556]

The fix should also be targeted to 15-x-y as the problematic path can be triggered when launching with --enable-crashpad

[deepak1556]

@codebytere updated the PR addressing the root issue.

[release-clerk]

Release Notes Persisted

Fixed an issue where app.getPath('crashDumps') returned an incorrect path for Linux.

[trop]

I have automatically backported this PR to "16-x-y", please check out #31711

[trop]

I have automatically backported this PR to "15-x-y", please check out #31712

[timfish]

The fix should also be targeted to 15-x-y as the problematic path can be triggered when launching with --enable-crashpad

I had already tested v15 with --enable-crashpad for @sentry/electron and didn't see any issues with app.getPath('crashDumps') 🤔

I only noticed it failing when trying v16 🤔