Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant crashpad patch for linux #31567

Closed
wants to merge 1 commit into from
Closed

chore: remove redundant crashpad patch for linux #31567

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Description of Change

Should no longer be needed following #30278.

Checklist

Release Notes

Notes: none.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/16-x-y labels Oct 25, 2021
@codebytere codebytere requested a review from a team as a code owner October 25, 2021 09:16
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2021
deepak1556
deepak1556 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if build is fine.

jkleinsc
jkleinsc requested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux fails to build

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 26, 2021
@codebytere
Copy link
Member Author

Gonna try to upstream this instead.

@codebytere codebytere closed this Nov 17, 2021
@codebytere codebytere deleted the delete-crashpad-patch branch November 17, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc requested changes

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @deepak1556