fix: pressing ESC should exit fullscreen from webview #30063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Jul 9, 2021
miniak
approved these changes
Jul 12, 2021
zcbenz
force-pushed
the
fix-webview-fullscreen-win
branch
from
dad59aa
to
d9f8135
Compare
zcbenz
force-pushed
the
fix-webview-fullscreen-win
branch
from
d9f8135
to
cdf0b5a
Compare
|
Release Notes Persisted
|
|
I was unable to backport this PR to "13-x-y" cleanly; |
|
I was unable to backport this PR to "12-x-y" cleanly; |
|
I have automatically backported this PR to "14-x-y", please check out #30127 |
miniak
pushed a commit
that referenced
this pull request
Jul 14, 2021
zcbenz
added a commit
that referenced
this pull request
Jul 15, 2021
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #27719.
There is a small problem with the issue's fix #29952 that, after entering fullscreen from webview, pressing ESC does not exit fullscreen for the window.
This is caused by native window fullscreen state not synchronized with html fullscreen state, it was intended because I thought there was no need to do so.
Release Notes
Notes: Fix pressing ESC not exiting fullscreen from
webview.