Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pressing ESC should exit fullscreen from webview #30137

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix: pressing ESC should exit fullscreen from webview #30137

merged 1 commit into from
Jul 15, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 14, 2021

Backport of #30063

See that PR for details.

Notes: Fix pressing ESC not exiting fullscreen from webview.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
@trop trop bot mentioned this pull request Jul 14, 2021
Merged
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
ckerr
ckerr approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward manual backport; trop just got tripped up on an import line diff

@zcbenz zcbenz merged commit 705a9a3 into 12-x-y Jul 15, 2021
@zcbenz zcbenz deleted the miniak/fix-webview-fullscreen-win-12-x-y branch July 15, 2021 02:42
@release-clerk
Copy link

release-clerk bot commented Jul 15, 2021

Release Notes Persisted

Fix pressing ESC not exiting fullscreen from webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @ckerr @zcbenz