fix: pressing ESC should exit fullscreen from webview #30127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
trop
bot
added
14-x-y
backport
zcbenz
approved these changes
Jul 15, 2021
zcbenz
deleted the
trop/14-x-y-bp-fix-pressing-esc-should-exit-fullscreen-from-webview-1626263501218
branch
|
Release Notes Persisted
|
|
Hi there! It looks like there are still issues with this PR. It turns out that the webview is not firing the leave-html-full-screen event when pressing ESC to exit fullscreen. I'll create an issue on it now as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30063
See that PR for details.
Notes: Fix pressing ESC not exiting fullscreen from
webview.