New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Initialize logging for crashpad #26250
Conversation
osx-x64 has failing crash reporter tests due to DCHECK crash in handler,
|
Is this a straight backport or is the patch modified? |
Crashpad patch from https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2425108 Patches have not been modified, just cherry-picked from different commits. |
- '76a9bb7475f6217eaf108789246379d3972b4e6a', | ||
+ '5fc64bfbf1c000161445c586de45e40464ff2314', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patches to DEPS don't work as the dep is synced before our patches are applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be ignored, mini_chromium is not used when crashpad is built inside chromium
Release Notes Persisted
|
I have automatically backported this PR to "10-x-y", please check out #26266 |
I have automatically backported this PR to "9-x-y", please check out #26267 |
Description of Change
On windows the default logging mode is LOG_TO_FILE and crashpad has been operating under this mode. The default log file will be created under the executable directory but when the executable is installed under restrictive directories like
C:\Program Files
the app won't have permission to write log files here and thereby creatingdebug.log
file under the working directoryCrbug - https://bugs.chromium.org/p/chromium/issues/detail?id=711159
Refs microsoft/vscode#105191
Checklist
npm test
passesRelease Notes
Notes: fix debug.log files being created under working directory on windows