Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Initialize logging for crashpad #26266

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

Backport of #26250

See that PR for details.

Notes: fix debug.log files being created under working directory on windows

@trop trop bot requested a review from a team as a code owner October 29, 2020 23:24
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 29, 2020
@trop trop bot requested a review from deepak1556 October 29, 2020 23:24
@trop trop bot mentioned this pull request Oct 29, 2020
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 29, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 29, 2020
patches/chromium/.patches Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the trop/10-x-y-bp-fix-initialize-logging-for-crashpad-1604013848799 branch from 2d57e06 to 4f57b97 Compare November 2, 2020 23:59
@zcbenz
Copy link
Member

zcbenz commented Nov 3, 2020

The patch fails to apply.

@deepak1556
Copy link
Member

Missed this, will look into it. Thanks!

@jkleinsc jkleinsc merged commit 0aef4d6 into 10-x-y Nov 10, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 10, 2020

Release Notes Persisted

fix debug.log files being created under working directory on windows

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants