New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.53 creates debug.log automatically #115874
Comments
I can confirm I experienced this issue with 1.49. I believe it was resolved in 1.49.2 (I no longer experienced it at that point). Now the issue seems to have returned in 1.53. VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T20:36:38.611Z) System Info
Extensions (46)
A/B Experiments
|
Can you provide the exact repro steps that created the log, I cannot repro with the steps from previous issue using system install. Thanks! |
I did a little testing, and here's what I've come up with. With no vscode instances open, I navigate in Windows Explorer to the folder I want to open in vscode. I right click on the folder in the Explorer tree on the left of Windows Explorer and select "Open with Code". the With at least one instance of vscode open (which as stated above is unaffected by the Further info. I have opened git repos, folders that are not git repos, and even created new empty folders and opened them in vscode. All of the above are affected and |
Also here are the contents of the file:
|
Same for me:
Also, the instance that created the debug.log file must be closed in order for the debug.log file to be deleted. |
P.s. I confirmed closing all vscode instances and switching the order of the folders opened still results in the second instance opened having Also I'm running a system install (not user) |
Thanks for the steps in #115874 (comment), I am able to repro the issue. |
Crashpad handler gets instantiated the following way on windows,
Fix at #116252 will now take pipe from the original instance and give it to all the instances that are connecting to it. As for the original
So it is unclear why the |
1.53.1 seems to have resolved the issue for me. Version: 1.53.1 (system setup) |
Negative, I'm on 1.53.1 and the issue still persists. How is it possible you don't have it if the fix was released 7 hours ago? |
Something else in 1.53.1 may have affected it? I'm not sure. But I am am unable to reproduce the issue on 1.53.1. |
I can confirm, I am having the issue on 1.53.1 too. To reproduce I just have to open second VSCode window with another repository. Version: 1.53.1 (system setup) |
Can you check if the issue persists with the latest insiders https://code.visualstudio.com/insiders |
Just reproduced on a different machine running 1.53.1 |
/verified |
Could not reproduce on Version: 1.54.0-insider (user setup) |
/verified |
@deepak1556 Has the underlying problem (writing log files into arbitrary user directories) been solved or is this just treating the symptoms "we fixed the problem that caused the error in this particular case"? If it's the latter it sounds like a good idea to create a new issue to actually fix the problem of log files getting written to the wrong place - otherwise we'll just have the same problem again in a few months. I might want to look into this if I find time. |
@danstur as mentioned here #115874 (comment) The fix was made for the error seen in the log
As for the original
You are right, but without a reliable repro, I can't validate why the logging preferences set by the runtime are being ignored. |
1.53.2 seems to have fixed the issue on both of my systems. Thanks! |
All good with 1.53.2. Thanks for the quick fix! Happy coding! |
Issue Type: Bug
Apparently it's an old issue #105191 (comment)
I have the same behaviour: open the first window (no debug.log file) -> open the second window (debug.log file was created automatically)
VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.19041
System Info
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Extensions (25)
The text was updated successfully, but these errors were encountered: