Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress worldSafe warning emitted from security checks #25827

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 8, 2020

Backport of #25692

See that PR for details.

Closes #25336.

Notes: Suppressed a spurious warning about executeJavaScript being called without worldSafeExecuteJavaScript being enabled in apps that do not call executeJavaScript.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 8, 2020
@trop trop bot requested a review from nornagon October 8, 2020 18:41
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 8, 2020
@codebytere codebytere merged commit 56a764d into 10-x-y Oct 9, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2020

Release Notes Persisted

Suppressed a spurious warning about executeJavaScript being called without worldSafeExecuteJavaScript being enabled in apps that do not call executeJavaScript.

@codebytere codebytere deleted the trop/10-x-y-bp-fix-suppress-worldsafe-warning-emitted-from-security-checks-1602182467210 branch October 9, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants