Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning in default repo #25336

Closed
moje01konto opened this issue Sep 5, 2020 · 6 comments
Closed

warning in default repo #25336

moje01konto opened this issue Sep 5, 2020 · 6 comments
Labels

Comments

@moje01konto
Copy link

moje01konto commented Sep 5, 2020

electron/js2c/renderer_init.js:14 (electron) Security Warning: webFrame.executeJavaScript was called without worldSafeExecuteJavaScript enabled. This is considered unsafe. worldSafeExecuteJavaScript will be enabled by default in Electron 12.
I delete renderer.js, preload etc. and still have this warning

@Nantris
Copy link
Contributor

Nantris commented Sep 7, 2020

Confirming this issue. Reproducible by creating a default Electron Fiddle with version 10.1.1.

image

@ghost
Copy link

ghost commented Oct 8, 2020

Right now it looks like executeJavaScript is called for every window opened by Electron to test worldSafeExecuteJavaScript, which if you don't have enabled will trigger the warning regardless if you're using it or not in your code.

@Nantris
Copy link
Contributor

Nantris commented Oct 8, 2020

@Kenneth-Markus-Williams is that a hypothesis or is there some code you can point to showing that's the cause?

@nornagon
Copy link
Member

nornagon commented Oct 8, 2020

This is fixed by #25692, looks like we need to backport to 10.

@rosshamish
Copy link

Looks like this is already backported to 10. This issue can probably be closed.

@yang-hua-bin
Copy link

这太麻烦了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants