fix: suppress worldSafe warning emitted from security checks #25692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MarshallOfSound
approved these changes
Sep 29, 2020
codebytere
approved these changes
Sep 29, 2020
|
CI failures are unrelated; merging. |
|
Release Notes Persisted
|
|
/trop run backport-to 10-x-y |
|
The backport process for this PR has been manually initiated - |
|
/trop run backport-to 11-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "10-x-y", please check out #25827 |
|
I have automatically backported this PR to "11-x-y", please check out #25828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The "hello world" Electron app was emitting a warning about executeJavaScript being called without world-safe turned on, even though the client code wasn't calling executeJavaScript. It turns out the culprit was in the security warnings code. For now, suppress the warning by calling
_executeJavaScriptdirectly.Checklist
Release Notes
Notes: Suppressed a spurious warning about executeJavaScript being called without worldSafeExecuteJavaScript being enabled in apps that do not call executeJavaScript.