refactor: add a wrapper for wrangling uv handles. #25332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zcbenz
approved these changes
Sep 8, 2020
gittysachin
approved these changes
Sep 12, 2020
|
Release Notes Persisted
|
mlaurencin
pushed a commit
to mlaurencin/electron
that referenced
this pull request
Sep 16, 2020
* refactor: add a wrapper for wrangling uv handles. Part 1 of a fix for electron#25248, electron#22069. Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new UvHandle wrapper class which manages uv_handles' need for their closed() callback to be invoked before the handles' memory can be freed. * chore: make lint happy * refactor: use DCHECK_EQ() instead of DCHECK() * refactor: fix oops
|
/trop run backport-to 11-x-y,10-x-y |
|
The backport process for this PR has been manually initiated - |
|
The backport process for this PR has been manually initiated - |
This was referenced Sep 28, 2020
|
I have automatically backported this PR to "11-x-y", please check out #25661 |
|
I have automatically backported this PR to "10-x-y", please check out #25662 |
|
/trop run backport-to 9-x-y |
|
The backport process for this PR has been manually initiated - |
Closed
3 tasks
|
I have automatically backported this PR to "9-x-y", please check out #25663 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Part 1 of a fix for #25248, #22069.
Fixes #24965. (h/t @jkleinsc for spotting the connection)
This PR wraps the
uv_async_tobjects owned by NodeBindings and ElectronBindings inside a new UvHandle wrapper class which handlesuv_handle_ts' specific rules about destruction:The UvHandle wrapper class handles this close-delete twostep so that client code doesn't have to think about it. Failure to finish closing before freeing is what caused the uv_walk() crash in #25248.
CC @codebytere
Checklist
npm testpassesRelease Notes
Notes: Fixed resource leak in worker threads.