Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add a wrapper for wrangling uv handles. #25662

Merged
merged 4 commits into from Sep 28, 2020
Merged

refactor: add a wrapper for wrangling uv handles. #25662

merged 4 commits into from Sep 28, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 28, 2020

Backport of #25332

See that PR for details.

Notes: Fixed resource leak in worker threads.

@ckerr @electron-bot
refactor: add a wrapper for wrangling uv handles.
b73203b 
Part 1 of a fix for #25248, #22069.

Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new
UvHandle wrapper class which manages uv_handles' need for their closed()
callback to be invoked before the handles' memory can be freed.
@ckerr @electron-bot
chore: make lint happy
f87264e
@ckerr @electron-bot
refactor: use DCHECK_EQ() instead of DCHECK()
6793d6e
@ckerr @electron-bot
refactor: fix oops
b696881
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@trop trop bot requested a review from ckerr September 28, 2020 00:24
@trop trop bot mentioned this pull request Sep 28, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@codebytere codebytere merged commit 37bcb09 into 10-x-y Sep 28, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2020

Release Notes Persisted

Fixed resource leak in worker threads.

@codebytere codebytere deleted the trop/10-x-y-bp-refactor-add-a-wrapper-for-wrangling-uv-handles--1601252650480 branch September 28, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @ckerr