fix: avoid creating client_id file for empty DIR_CRASH_DUMPS

[deepak1556]

Description of Change

Node child process don't set DIR_CRASH_DUMPS unless the undocumented BREAKPAD_DUMP_LOCATION is specified, in these situations client_id file will be generated under the working directory.

Refs microsoft/vscode#105743

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed client_id file being generated in the working directory for Node.js child processes.

[nornagon]

hm... does this mean crashes in node child processes on linux won't come with a guid parameter?

Perhaps we should set BREAKPAD_DUMP_LOCATION for node child processes?

Thought of some more questions

[deepak1556]

Yeah thought about that, but I don't see a reasonable way to specify the value as base::PathService will be uninitialized in the node_main.cc which blocks us from extracting the DIR_USER_DATA. If we propagate the user data path via the process object then we can set the value here https://github.com/electron/electron/blob/master/patches/node/refactor_alter_child_process_fork_to_use_execute_script_with.patch or else we can just document BREAKPAD_DUMP_LOCATION for apps to specify.

[nornagon]

I was imagining setting the env var in childProcess.fork() as in that patch. But I guess there are other ways that apps could launch a RUN_AS_NODE process...

[nornagon]

I think the ultimate path forward here is to switch to crashpad on Linux, which we'll do eventually anyway.

[deepak1556]

I think the ultimate path forward here is to switch to crashpad on Linux, which we'll do eventually anyway.

yep

FWIW crash reporting from node child process wasn't working at all on linux before the refactor, so I think we can leave this as such until the crashpad move is made.

[release-clerk]

Release Notes Persisted

Fixed client_id file being generated in the working directory for Node.js child processes.

[trop]

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "10-x-y", please check out #25309

[trop]

I have automatically backported this PR to "11-x-y", please check out #25310

[trop]

@deepak1556 has manually backported this PR to "9-x-y", please check out #25316