fix: avoid creating client_id file for empty DIR_CRASH_DUMPS #25316

deepak1556 · 2020-09-03T23:09:07Z

Backports #25296

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed client_id file being generated in the working directory for Node.js child processes.

release-clerk · 2020-09-04T01:46:33Z

Release Notes Persisted

Fixed client_id file being generated in the working directory for Node.js child processes.

fix: avoid creating client_id file for empty DIR_CRASH_DUMPS

da8911b

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020

trop bot mentioned this pull request Sep 3, 2020

fix: avoid creating client_id file for empty DIR_CRASH_DUMPS #25296

Merged

6 tasks

trop bot added 9-x-y backport This is a backport PR labels Sep 3, 2020

deepak1556 requested a review from a team September 3, 2020 23:09

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020

codebytere approved these changes Sep 4, 2020

View reviewed changes

codebytere merged commit 79c1c8d into 9-x-y Sep 4, 2020

codebytere deleted the robo/fix_client_id_9_x branch September 4, 2020 01:46

Provide feedback