Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid creating client_id file for empty DIR_CRASH_DUMPS #25310

Merged
merged 1 commit into from Sep 4, 2020
Merged

fix: avoid creating client_id file for empty DIR_CRASH_DUMPS #25310

merged 1 commit into from Sep 4, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 3, 2020

Backport of #25296

See that PR for details.

Notes: fix client_id file being generated in the working directory for node child process

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@trop trop bot requested a review from deepak1556 September 3, 2020 18:53
@trop trop bot mentioned this pull request Sep 3, 2020
Merged
6 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@codebytere codebytere merged commit a08b368 into 11-x-y Sep 4, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 4, 2020

Release Notes Persisted

fix client_id file being generated in the working directory for node child process

@codebytere codebytere deleted the trop/11-x-y-bp-fix-avoid-creating-client_id-file-for-empty-dir_crash_dumps-1599159180038 branch September 4, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @deepak1556