New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bind fake mojo service for badging #25294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick test? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible we could actually support the badging service? We do expose the relevant APIs...
@nornagon not as it stands without massive patching, given that the Chromium impl is per-Profile. For now, i think in the short term we should mitigate this crash, although I do think there are some paths forward here. At minimum, we should look towards adding badging support for Windows. Once that's done, I think we can look to bind this to our own badging APIs 🤔 I can open a follow-up issue about adding Windows support if that seems like something we feel would be the next best step. |
Can we expose the events to the main process and let the app figure it out? |
Potentially? Wiring up the events would almost certainly require a fair bit of patching as well, and at that point it seems more prudent to actually support badging on Windows and wire it up more properly 🤔 |
I think it still makes sense to give the app control over what's allowed to badge, for instance. |
I assume it is OK to merge this PR? Providing some APIs to implement |
Release Notes Persisted
|
I have automatically backported this PR to "10-x-y", please check out #25369 |
I have automatically backported this PR to "11-x-y", please check out #25370 |
I have automatically backported this PR to "9-x-y", please check out #25371 |
Description of Change
Closes #25141.
Bind a fake mojo service for the Badging API. When users add e.g.
navigator.setAppBadge(42)
to the renderer, they will now seelogged as a warning.
cc @nornagon @MarshallOfSound @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Fixed a crash in the renderer process when invoking the Badging API.