Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: navigator.setAppBadge/clearAppBadge #27067

Merged
merged 1 commit into from Jan 21, 2021
Merged

fix: navigator.setAppBadge/clearAppBadge #27067

merged 1 commit into from Jan 21, 2021

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Dec 17, 2020 •
edited

Description of Change

This PR fixes using navigator.setAppBadge and navigator.clearAppBadge in Electron.

While #25294 resolved a crash calling navigator.setAppBadge, this resolves #25141 by implementing the APIs in Electron.

Checklist

Release Notes

Notes: Fixed using navigator.setAppBadge and navigator.clearAppBadge in Electron.

@jkleinsc jkleinsc added semver/minor backwards-compatible functionality target/11-x-y labels Dec 17, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Dec 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 24, 2020
zcbenz
zcbenz reviewed Jan 6, 2021
View reviewed changes
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
shell/browser/ui/win/taskbar_host.cc Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
shell/browser/badging/badge_manager.cc Show resolved Hide resolved
@zcbenz
Copy link
Member

zcbenz commented Jan 11, 2021

Also this PR has some overlap with #24051.

@codebytere codebytere self-requested a review January 14, 2021 16:04
@jkleinsc jkleinsc requested review from MarshallOfSound, ckerr and a team January 14, 2021 16:14
@jkleinsc jkleinsc force-pushed the enable-set-app-badge branch 2 times, most recently from 26bd5d0 to 67dadac Compare January 19, 2021 20:18
@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes and removed semver/minor backwards-compatible functionality api-review/requested 🗳 labels Jan 19, 2021
@jkleinsc jkleinsc changed the title feat: enable navigator.setAppBadge/clearAppBadge fix: enable navigator.setAppBadge/clearAppBadge Jan 19, 2021
@jkleinsc jkleinsc changed the title fix: enable navigator.setAppBadge/clearAppBadge fix: navigator.setAppBadge/clearAppBadge Jan 19, 2021
@jkleinsc jkleinsc removed request for a team, MarshallOfSound and ckerr January 19, 2021 20:27
@jkleinsc jkleinsc requested a review from zcbenz January 19, 2021 22:23
zcbenz
zcbenz reviewed Jan 20, 2021
View reviewed changes
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
shell/browser/browser.h Outdated Show resolved Hide resolved
shell/browser/browser.h Outdated Show resolved Hide resolved
shell/browser/browser.h Outdated Show resolved Hide resolved
shell/browser/browser_win.cc Outdated Show resolved Hide resolved
docs/api/app.md Outdated Show resolved Hide resolved
@jkleinsc jkleinsc requested a review from zcbenz January 21, 2021 00:00
@zcbenz zcbenz merged commit c5a41de into master Jan 21, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 21, 2021

Release Notes Persisted

Fixed using navigator.setAppBadge and navigator.clearAppBadge in Electron.

@zcbenz zcbenz deleted the enable-set-app-badge branch January 21, 2021 05:45
@trop
Copy link
Contributor

trop bot commented Jan 21, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jan 21, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jan 21, 2021

I have automatically backported this PR to "12-x-y", please check out #27431

@jkleinsc jkleinsc mentioned this pull request Mar 2, 2021
Merged
4 tasks
@jkleinsc jkleinsc mentioned this pull request Jun 9, 2022
Closed
3 tasks
@miniak miniak mentioned this pull request Sep 20, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renderer crash after calling navigator.setAppBadge(42)
2 participants
@jkleinsc @zcbenz