Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bind fake mojo service for badging #25371

Merged
merged 2 commits into from Sep 10, 2020
Merged

fix: bind fake mojo service for badging #25371

merged 2 commits into from Sep 10, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 8, 2020

Backport of #25294

See that PR for details.

Notes: Fixed a crash in the renderer process when invoking the Badging API.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2020
@trop trop bot requested a review from codebytere September 8, 2020 15:14
@trop trop bot mentioned this pull request Sep 8, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2020
@zcbenz zcbenz merged commit 7de2539 into 9-x-y Sep 10, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2020

Release Notes Persisted

Fixed a crash in the renderer process when invoking the Badging API.

@zcbenz zcbenz deleted the trop/9-x-y-bp-fix-bind-fake-mojo-service-for-badging-1599578057275 branch September 10, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere