Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maven.frontend.failOnError and maven.test.failure.ignore support #553

Closed
wants to merge 6 commits into from

Conversation

ningod
Copy link

@ningod ningod commented Jan 11, 2017

Added flags to best manage integration-test

This pull request resolve the need to have some configuration to ignore failures during build, expecially to manage maven integration-test phases (pre and post) as explained in: #552

jcarsique added a commit to jcarsique/frontend-maven-plugin that referenced this pull request Feb 20, 2017
…est.failure.ignore properties

fix integration-test
eval failOnError depending on the property set and isTestingPhase()
@mriehema
Copy link
Contributor

mriehema commented Mar 1, 2017

Looks like this PR, PR #572 and PR #564 fix the same.
My favorite is #572 because it includes documentation and release notes.
@ningod Could you check, if PR #572 works for you? If yes, could you close your PR?

@ningod ningod closed this Mar 3, 2017
@ningod ningod reopened this Mar 3, 2017
@ningod
Copy link
Author

ningod commented Mar 3, 2017

Pull Request is still open due to corrections on documentation ( README.md )

@mriehema
Copy link
Contributor

mriehema commented Mar 3, 2017

Could you please open a new PR with just the documentation fixes? This PR includes all the other commits and even the appveyor configuration. Thx.

@ningod ningod closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants