add failOnError and integration-test support #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maven.test.failure.ignore property from KarmaRunMojo to AbstractFrontendMojo to manage integration-test phases updated README.md and CHANGELOG.md
…est.failure.ignore properties fix integration-test eval failOnError depending on the property set and isTestingPhase()
ningod
approved these changes
Feb 23, 2017
This was referenced Mar 1, 2017
|
LGTM, what do you think @eirslett? |
|
Ok thanks, I'll merge this version! |
|
This PR was reverted due to #613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses and fixes PR #553 , solving issue #552 ; see also #534 closed as duplicate.
Current behavior: an execution failure stops the Maven build. This is an issue for instance when the plugin is used to execute tests. Moreover, after an
integration-testphase, it is often required to execute thepost-integration-testphase for environment cleanup and tear down.Expected behavior:
failOnErrorpropertyfailOnError==true, keep the current behavior (BUILD FAILURE)failOnError==false, don't fail the Maven build (BUILD ERROR)That is compliant with the common behavior encountered on the Maven plugins.
Tested on frontend-maven-plugin 1.4-SNAPSHOT