closes #534: Do not fail the Maven build for a failed test #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for testFailureIgnore flag as in Surefire plugin
kaqqao
changed the title
Added support for testFailureIgnore flag as in Surefire plugin
|
Please merge and release this asap, it's just what I need! Thanks! 👍 |
|
Yes, I'd be quite happy to get any of the PRs merged. Not particularly attached to mine. #572 seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added general support for
testFailureIgnore(maven.test.failure.ignore) flag as in Surefire plugin (this closes #534). Currently only Karma mojo respects this flag, making it impossible to apply it to Protractor or any other tests.In case this flag is set to
true, a failure duringtestorintegration-testphase will not fail the entire build, but just log the error.Property name (to add to the
<configuration>block):testFailureIgnoreUser property (to add as command line argument, or the
<properties>block):maven.test.failure.ignoreThe change is minimal, and the flag itself, the behavior, and the implementation are all consistent with Surefire plugin:
EDIT
Seems like a similar pull request already exists: #553