Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquarantine tests / skip mslocaldb helix tests #38814

Merged
merged 8 commits into from Dec 4, 2021
Merged

Unquarantine tests / skip mslocaldb helix tests #38814

merged 8 commits into from Dec 4, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Dec 3, 2021

Fixes #37930
Fixes #34284
Fixes #31729
Fixes #37930

Parole for:

  • 2 non playwright blazor template tests that were grouped in the playwright template test issue, these are fairly reliable and have been clean for 30 days
  • FileLoggerProcessor test was improved by community PRs
  • Http2ConnectionTest that was missing a test-fixed label that has been 30 days clean
  • Switch to retry instead of perma quarantine for MaxRequestBufferSizeTests.LargeUpload as its been 30 days clean

image

@HaoK HaoK marked this pull request as ready for review December 3, 2021 18:43
@HaoK HaoK enabled auto-merge (squash) December 3, 2021 18:43
@HaoK HaoK disabled auto-merge December 3, 2021 19:09
@HaoK HaoK requested a review from a team as a code owner December 3, 2021 19:10
@HaoK
Copy link
Member Author

HaoK commented Dec 3, 2021

@dotnet/aspnet-blazor-eng fyi we've been seeing the playwright versions of BlazorTemplate tests fail recently, so I'm going to take it out of helix runs for now and file an issue if you want to bring these back in the future, I believe all of the tests in the playwright version of BlazorTemplates are quarantined anyways, so there should not be any loss of coverage

@HaoK
Copy link
Member Author

HaoK commented Dec 3, 2021

Filed #38818 for tracking the playwright blazortemplate.tests being skipped on helix

@HaoK HaoK enabled auto-merge (squash) December 3, 2021 22:11
@HaoK
Copy link
Member Author

HaoK commented Dec 4, 2021

Looks like the hang issue is TestDependsOnMssql as Diagnostics functionals is also hanging, will skip and file an issue for that as well

@HaoK HaoK changed the title Unquarantine tests Unquarantine tests / skip mslocaldb helix tests Dec 4, 2021
@HaoK HaoK merged commit 9c29067 into main Dec 4, 2021
@HaoK HaoK deleted the haok/parole branch December 4, 2021 02:09
@ghost ghost added this to the 7.0-preview1 milestone Dec 4, 2021
@dougbu
Copy link
Member

dougbu commented Feb 8, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1813530482

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

@dougbu backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update BlazorServerTemplateTest.cs
Applying: Update RazorPagesTemplateTest.cs
Applying: Update Http2ConnectionTests.cs
Using index info to reconstruct a base tree...
M	src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
CONFLICT (content): Merge conflict in src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Update Http2ConnectionTests.cs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

pranavkm added a commit to pranavkm/aspnetcore that referenced this pull request Feb 9, 2022
@pranavkm
Copy link
Contributor

pranavkm commented Feb 9, 2022

@dougbu backporting to release/6.0 failed, the patch most likely resulted in conflicts:

Some dolt updated this repo to use file scoped namespaces in main, so it's super hard to port these changes without conflicts. #40101 redoes this PR manually.

pranavkm added a commit that referenced this pull request Feb 11, 2022
Elanis pushed a commit to Elanis/portfolio that referenced this pull request Dec 13, 2022
Bumps [Microsoft.AspNetCore.TestHost](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>

*Sourced from [Microsoft.AspNetCore.TestHost's releases](https://github.com/dotnet/aspnetcore/releases).*

> ## .NET 6.0.3
> [Release](https://github.com/dotnet/core/tree/v6.0.3)
</details>
<details>
<summary>Commits</summary>

- [`c911002`](dotnet/aspnetcore@c911002) Merged PR 21440: [internal/release/6.0] Update dependencies from dnceng/inter...
- [`5049143`](dotnet/aspnetcore@5049143) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime
- [`04bc56b`](dotnet/aspnetcore@04bc56b) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore...
- [`f01a14d`](dotnet/aspnetcore@f01a14d) Merge in 'release/6.0' changes
- [`d5d2e4d`](dotnet/aspnetcore@d5d2e4d) [release/6.0] Extend disable component governance for linux ([#40158](dotnet/aspnetcore#40158))
- [`e7bfbce`](dotnet/aspnetcore@e7bfbce) Merge in 'release/6.0' changes
- [`00d34c3`](dotnet/aspnetcore@00d34c3) Port dotnet/aspnetcore#38814 to 6.0 ([#40101](dotnet/aspnetcore#40101))
- [`8dfa6ac`](dotnet/aspnetcore@8dfa6ac) Merge in 'release/6.0' changes
- [`006f1b8`](dotnet/aspnetcore@006f1b8) Fix 5.0 SiteExtension Version ([#40121](dotnet/aspnetcore#40121))
- [`372292b`](dotnet/aspnetcore@372292b) Merge in 'release/6.0' changes
- Additional commits viewable in [compare view](dotnet/aspnetcore@v6.0.2...v6.0.3)
</details>

<br />

Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/29
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>
Elanis added a commit to Dysnomia-Studio/dysnomia-website that referenced this pull request Jul 14, 2023
Bumps [Microsoft.AspNetCore.TestHost](https://github.com/dotnet/aspnetcore) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>

*Sourced from [Microsoft.AspNetCore.TestHost's releases](https://github.com/dotnet/aspnetcore/releases).*

> ## .NET 6.0.3
> [Release](https://github.com/dotnet/core/tree/v6.0.3)
</details>
<details>
<summary>Commits</summary>

- [`c911002`](dotnet/aspnetcore@c911002) Merged PR 21440: [internal/release/6.0] Update dependencies from dnceng/inter...
- [`5049143`](dotnet/aspnetcore@5049143) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime
- [`04bc56b`](dotnet/aspnetcore@04bc56b) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore...
- [`f01a14d`](dotnet/aspnetcore@f01a14d) Merge in 'release/6.0' changes
- [`d5d2e4d`](dotnet/aspnetcore@d5d2e4d) [release/6.0] Extend disable component governance for linux ([#40158](dotnet/aspnetcore#40158))
- [`e7bfbce`](dotnet/aspnetcore@e7bfbce) Merge in 'release/6.0' changes
- [`00d34c3`](dotnet/aspnetcore@00d34c3) Port dotnet/aspnetcore#38814 to 6.0 ([#40101](dotnet/aspnetcore#40101))
- [`8dfa6ac`](dotnet/aspnetcore@8dfa6ac) Merge in 'release/6.0' changes
- [`006f1b8`](dotnet/aspnetcore@006f1b8) Fix 5.0 SiteExtension Version ([#40121](dotnet/aspnetcore#40121))
- [`372292b`](dotnet/aspnetcore@372292b) Merge in 'release/6.0' changes
- Additional commits viewable in [compare view](dotnet/aspnetcore@v6.0.2...v6.0.3)
</details>

<br />

Co-authored-by: Elanis <elanis@hotmail.com>
Reviewed-on: https://gitea.dysnomia.studio/elanis/dysnomia-website/pulls/34
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants