Skip to content

Commit

Permalink
Unquarantine tests / skip BlazorTemplateTests
Browse files Browse the repository at this point in the history
  • Loading branch information
HaoK committed Dec 4, 2021
1 parent 76c3bec commit 9c29067
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 5 deletions.
Expand Up @@ -5,6 +5,9 @@
<SignAssembly>false</SignAssembly>
<AssemblyName>Diagnostics.FunctionalTests</AssemblyName>
<TestDependsOnMssql>true</TestDependsOnMssql>

<!-- https://github.com/dotnet/aspnetcore/issues/38819 LocalDb sometimes hangs on win11 helix queue -->
<BuildHelixPayload>false</BuildHelixPayload>
</PropertyGroup>

<ItemGroup>
Expand Down
Expand Up @@ -115,7 +115,6 @@ await using (var logger = new FileLoggerProcessor(new OptionsWrapperMonitor<W3CL
}
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34284")]
[Fact]
public async Task RollsTextFilesBasedOnSize()
{
Expand Down
Expand Up @@ -9,6 +9,9 @@
<BaseOutputPath />
<OutputPath />

<!-- https://github.com/dotnet/aspnetcore/issues/38818 -->
<BuildHelixPayload>false</BuildHelixPayload>

<!-- Properties that affect test runs -->
<!-- TestTemplateCreationFolder is the folder where the templates will be created. Will point out to $(OutputDir)$(TestTemplateCreationFolder) -->
<TestTemplateCreationFolder>TestTemplates\</TestTemplateCreationFolder>
Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/BlazorServerTemplateTest.cs
Expand Up @@ -38,7 +38,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory)
[InlineData("SingleOrg", null)]
[InlineData("SingleOrg", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public Task BlazorServerTemplate_IdentityWeb_BuildAndPublish(string auth, string[] args)
=> CreateBuildPublishAsync("blazorserveridweb" + Guid.NewGuid().ToString().Substring(0, 10).ToLowerInvariant(), auth, args);

Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/RazorPagesTemplateTest.cs
Expand Up @@ -232,7 +232,6 @@ public async Task RazorPagesTemplate_IndividualAuth(bool useLocalDB)

[ConditionalTheory]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31729")]
public Task RazorPagesTemplate_IdentityWeb_BuildsAndPublishes_WithSingleOrg(string auth, string[] args) => BuildAndPublishRazorPagesTemplate(auth: auth, args: args);

private async Task<Project> BuildAndPublishRazorPagesTemplate(string auth, string[] args)
Expand Down
Expand Up @@ -115,7 +115,7 @@ public static IEnumerable<object[]> LargeUploadData
}
[Theory]
[MemberData(nameof(LargeUploadData))]
[QuarantinedTest("This is inherently flaky and should never be unquarantined.")]
// This is inherently flaky and is relying on helix retry to pass consistently
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
{
// Parameters
Expand Down
Expand Up @@ -235,7 +235,6 @@ public ResponseTrailersWrapper(IHeaderDictionary headers)
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/37930")]
public async Task ResponseTrailers_MultipleStreams_Reset()
{
IEnumerable<KeyValuePair<string, string>> requestHeaders = new[]
Expand Down

0 comments on commit 9c29067

Please sign in to comment.