Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unquarantine tests / skip mslocaldb helix tests #38814

Merged
merged 8 commits into from Dec 4, 2021
Merged

Unquarantine tests / skip mslocaldb helix tests #38814

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89e9dd5
Update BlazorServerTemplateTest.cs
HaoK Dec 3, 2021
688fad1
Update RazorPagesTemplateTest.cs
HaoK Dec 3, 2021
de2c3fa
Update Http2ConnectionTests.cs
HaoK Dec 3, 2021
443e77e
Update FileLoggerProcessorTests.cs
HaoK Dec 3, 2021
132d916
Update MaxRequestBufferSizeTests.cs
HaoK Dec 3, 2021
7d778a8
Add retry rule for LargeUpload test
HaoK Dec 3, 2021
e1c0286
Skip playwright blazor template tests on helix
HaoK Dec 3, 2021
b74f978
Skip on helix due to installlocaldb hangs on win11
HaoK Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs
View file
Open in desktop
Expand Up @@ -115,7 +115,6 @@ await using (var logger = new FileLoggerProcessor(new OptionsWrapperMonitor<W3CL
}
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34284")]
[Fact]
public async Task RollsTextFilesBasedOnSize()
{
Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/BlazorServerTemplateTest.cs
View file
Open in desktop
Expand Up @@ -38,7 +38,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory)
[InlineData("SingleOrg", null)]
[InlineData("SingleOrg", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public Task BlazorServerTemplate_IdentityWeb_BuildAndPublish(string auth, string[] args)
=> CreateBuildPublishAsync("blazorserveridweb" + Guid.NewGuid().ToString().Substring(0, 10).ToLowerInvariant(), auth, args);

Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/RazorPagesTemplateTest.cs
View file
Open in desktop
Expand Up @@ -232,7 +232,6 @@ public async Task RazorPagesTemplate_IndividualAuth(bool useLocalDB)

[ConditionalTheory]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31729")]
public Task RazorPagesTemplate_IdentityWeb_BuildsAndPublishes_WithSingleOrg(string auth, string[] args) => BuildAndPublishRazorPagesTemplate(auth: auth, args: args);

private async Task<Project> BuildAndPublishRazorPagesTemplate(string auth, string[] args)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs
View file
Open in desktop
Expand Up @@ -115,7 +115,7 @@ public static IEnumerable<object[]> LargeUploadData
}
[Theory]
[MemberData(nameof(LargeUploadData))]
[QuarantinedTest("This is inherently flaky and should never be unquarantined.")]
// This is inherently flaky and is relying on helix retry to pass consistently
halter73 marked this conversation as resolved.
Show resolved Hide resolved
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
{
// Parameters
Expand Down
1 change: 0 additions & 1 deletion src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
View file
Open in desktop
Expand Up @@ -235,7 +235,6 @@ public ResponseTrailersWrapper(IHeaderDictionary headers)
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/37930")]
public async Task ResponseTrailers_MultipleStreams_Reset()
{
IEnumerable<KeyValuePair<string, string>> requestHeaders = new[]
Expand Down