Use Xunit runner that is compatible with .NET 5 #5908
Conversation
Using the 2.4.1 version of the runner fails with "Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again." when executing `dotnet test` on .NET 5 project. 2,4,3 was specifically released to address this. See xunit/visualstudio.xunit#229.
| @@ -86,7 +86,7 @@ | |||
| <MicrosoftTestPlatformVersion Condition="'$(MicrosoftTestPlatformVersion)' == ''">16.5.0</MicrosoftTestPlatformVersion> | |||
| <XUnitVersion Condition="'$(XUnitVersion)' == ''">2.4.1</XUnitVersion> | |||
| <XUnitRunnerConsoleVersion Condition="'$(XUnitRunnerConsoleVersion)' == ''">$(XUnitVersion)</XUnitRunnerConsoleVersion> | |||
| <XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">$(XUnitVersion)</XUnitRunnerVisualStudioVersion> | |||
| <XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">2.4.3</XUnitRunnerVisualStudioVersion> | |||
There was a problem hiding this comment.
Seems to be required for testing on 5.0, but needs a comment explaining why it's not the being set to $(XUnitVersion)
There was a problem hiding this comment.
Why not just.....update XUnitVersion?
There was a problem hiding this comment.
there isn't 2.4.3 on https://www.nuget.org/packages/xunit/
|
@tmat can you have a look? We're working around this in aspnetcore, but the experience is really problematic. |
|
@lpatalas I'd be happy for some one to merge this change. We've been using this version of Xunit for quite some time in dotnet/aspnetcore without issues. |
I went ahead and approved. |
Using < 2.4.3 version of the runner fails with "Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again." when executing
dotnet teston .NET 5 project. This version was specifically released to address this. See xunit/visualstudio.xunit#229.