Skip to content

Commit

Permalink
Use Xunit runner that is compatible with .NET 5 (#5908)
Browse files Browse the repository at this point in the history
* Use Xunit runner that is compatible with .NET 5

Using the 2.4.1 version of the runner fails with "Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again." when executing `dotnet test` on .NET 5 project. 2,4,3 was specifically released to address this. See xunit/visualstudio.xunit#229.
  • Loading branch information
pranavkm committed Aug 24, 2020
1 parent 5ba7b91 commit d8f74bf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props
Expand Up @@ -86,7 +86,8 @@
<MicrosoftTestPlatformVersion Condition="'$(MicrosoftTestPlatformVersion)' == ''">16.5.0</MicrosoftTestPlatformVersion>
<XUnitVersion Condition="'$(XUnitVersion)' == ''">2.4.1</XUnitVersion>
<XUnitRunnerConsoleVersion Condition="'$(XUnitRunnerConsoleVersion)' == ''">$(XUnitVersion)</XUnitRunnerConsoleVersion>
<XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">$(XUnitVersion)</XUnitRunnerVisualStudioVersion>
<!-- Version 2.4.3 of xunit.runner.visualstudio was released to fix testing of net5 projects without updating any other xunit packages -->
<XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">2.4.3</XUnitRunnerVisualStudioVersion>
<MSTestVersion Condition="'$(MSTestVersion)' == ''">2.0.0</MSTestVersion>
<MSTestTestAdapterVersion Condition="'$(MSTestTestAdapterVersion)' == ''">$(MSTestVersion)</MSTestTestAdapterVersion>
<MSTestTestFrameworkVersion Condition="'$(MSTestTestFrameworkVersion)' == ''">$(MSTestVersion)</MSTestTestFrameworkVersion>
Expand Down

0 comments on commit d8f74bf

Please sign in to comment.