Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XunitRunnerVisualStudioVersion from Version.props after Arcade update #24750

Closed
pranavkm opened this issue Aug 10, 2020 · 5 comments
Closed

Remove XunitRunnerVisualStudioVersion from Version.props after Arcade update #24750

pranavkm opened this issue Aug 10, 2020 · 5 comments
Labels
affected-very-few This issue impacts very few customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue. severity-nice-to-have This label is used by an internal tool Status: Resolved task

Comments

@pranavkm
Copy link
Contributor

To get tests running, AspNetCore's versions.props file explicitly specifies a version for XunitRunnerVisualStudio:

https://github.com/dotnet/aspnetcore/pull/24685/files#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR282

Once dotnet/arcade#5908 is merged and an Arcade update is available, this can be removed.
@pranavkm pranavkm added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 10, 2020
@pranavkm pranavkm mentioned this issue Aug 10, 2020
Merged
@pranavkm pranavkm added the blocked The work on this issue is blocked due to some dependency label Aug 10, 2020
@dougbu
Copy link
Member

dougbu commented Nov 15, 2020

@pranavkm why remove the property when it matches what Arcade provides and keeps all xUnit properties together❔ Arcade doesn't provide versions for many of the xUnit packages we use. And, we have a history of staying ahead of Arcade versions (admittedly, that's not the case for the few xUnit versions Arcade has at the moment).

@dougbu
Copy link
Member

dougbu commented Nov 18, 2020

/ping @pranavkm

1 similar comment
@wtgodbe
Copy link
Member

wtgodbe commented Dec 7, 2020

/ping @pranavkm

@wtgodbe wtgodbe added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool task labels Dec 7, 2020 — with ASP.NET Core Issue Ranking
@pranavkm
Copy link
Contributor Author

pranavkm commented Dec 7, 2020

I think @dougbu asked me to file this issue - see #24685 (comment).

@dougbu
Copy link
Member

dougbu commented Dec 7, 2020

Changed my mind on the value

@dougbu dougbu closed this as completed Dec 7, 2020
@dougbu dougbu added ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue. and removed blocked The work on this issue is blocked due to some dependency labels Dec 7, 2020
@ghost ghost added the Status: Resolved label Dec 7, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affected-very-few This issue impacts very few customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework ✔️ Resolution: Won't Fix Resolved because we decided not to change the behavior reported in this issue. severity-nice-to-have This label is used by an internal tool Status: Resolved task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pranavkm @dougbu @wtgodbe