Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions file output has redundant entries #727

Conversation

Hugo-Dahl-Tyler
Copy link
Contributor

This PR addresses the issues mentioned in #726, being:

  • Multiple repeated entries in the output file
  • Blank lines between entries in the output file

@dnfadmin
Copy link

dnfadmin commented Mar 3, 2022

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott added this to the v3.4 milestone Mar 6, 2022
Let the 'System.IO.File' provider handle newlines between entries rather than manually inserting them
Addresses item 2 of dotnet#726
@AArnott AArnott force-pushed the bugfix/GitHubActions-File-Output-Has-Redundant-Entries branch from e651f50 to b6e44c3 Compare March 6, 2022 21:31
@AArnott AArnott changed the base branch from master to v3.4 March 6, 2022 21:31
@AArnott
Copy link
Collaborator

AArnott commented Mar 6, 2022

I rebased your commits so we could merge into our v3.4 servicing branch, since v3.5 is still unstable and your fix is good to get out right away.

@AArnott AArnott enabled auto-merge March 6, 2022 21:32
@AArnott AArnott linked an issue Mar 6, 2022 that may be closed by this pull request
@AArnott AArnott merged commit d66ac53 into dotnet:v3.4 Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Output Has the Same Entries Multiple Times
3 participants