Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Output Has the Same Entries Multiple Times #726

Closed
Hugo-Dahl-Tyler opened this issue Mar 3, 2022 · 0 comments · Fixed by #727
Closed

File Output Has the Same Entries Multiple Times #726

Hugo-Dahl-Tyler opened this issue Mar 3, 2022 · 0 comments · Fixed by #727
Labels
Milestone

Comments

@Hugo-Dahl-Tyler
Copy link
Contributor

When running a cloud build for the "GitHubActions" CI system, and the process succeeds, the output file has 6 entries for each variable.

Additionally, there is an extra blank line between each entry in the file.

I've narrowed the issue down to the Utilities.FileOperationWithRetry(Action) method, which does not exit the for loop when operation() succeeds, and both prepends and appends Environment.NewLine to the line being written.

Hugo-Dahl-Tyler added a commit to Hugo-Dahl-Tyler/Nerdbank.GitVersioning that referenced this issue Mar 3, 2022
Hugo-Dahl-Tyler added a commit to Hugo-Dahl-Tyler/Nerdbank.GitVersioning that referenced this issue Mar 3, 2022
Let the 'System.IO.File' provider handle newlines between entries rather than manually inserting them
Addresses item 2 of dotnet#726
AArnott pushed a commit to Hugo-Dahl-Tyler/Nerdbank.GitVersioning that referenced this issue Mar 6, 2022
AArnott pushed a commit to Hugo-Dahl-Tyler/Nerdbank.GitVersioning that referenced this issue Mar 6, 2022
Let the 'System.IO.File' provider handle newlines between entries rather than manually inserting them
Addresses item 2 of dotnet#726
@AArnott AArnott linked a pull request Mar 6, 2022 that will close this issue
@AArnott AArnott added this to the v3.4 milestone Mar 6, 2022
@AArnott AArnott added the bug label Mar 6, 2022
@AArnott AArnott closed this as completed Mar 7, 2022
akobr pushed a commit to akobr/Nerdbank.GitVersioning that referenced this issue Mar 18, 2022
akobr pushed a commit to akobr/Nerdbank.GitVersioning that referenced this issue Mar 18, 2022
Let the 'System.IO.File' provider handle newlines between entries rather than manually inserting them
Addresses item 2 of dotnet#726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants