Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions file output has redundant entries #727

Merged
merged 2 commits into from Mar 6, 2022
+2 −1
Merged

GitHub actions file output has redundant entries #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9c33d
Break out of for loop on success
Hugo-Dahl-Tyler Mar 3, 2022
b6e44c3
Use 'File.AppendLine()' to generate output
Hugo-Dahl-Tyler Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NerdBank.GitVersioning/CloudBuildServices/GitHubActions.cs
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ internal class GitHubActions : ICloudBuild

public IReadOnlyDictionary<string, string> SetCloudBuildVariable(string name, string value, TextWriter stdout, TextWriter stderr)
{
Utilities.FileOperationWithRetry(() => File.AppendAllText(EnvironmentFile, $"{Environment.NewLine}{name}={value}{Environment.NewLine}"));
Utilities.FileOperationWithRetry(() => File.AppendAllLines(EnvironmentFile, new [] {$"{name}={value}"}));
return GetDictionaryFor(name, value);
}

Expand Down
1 change: 1 addition & 0 deletions src/Shared/Utilities.cs
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@ internal static void FileOperationWithRetry(Action operation)
try
{
operation();
break;
}
catch (IOException ex) when (ex.HResult == ProcessCannotAccessFileHR && retriesLeft > 0)
{
Expand Down